On Thu, 04 Dec 2008, Alan Jenkins wrote: > I still think you need to initialise wifi_rfkill->state before you call > rfkill_register(). > > It seems an easy mistake, probably the rfkill core should test for it. Well, yes, I could add that paranoia to the core. Added to the todo list. But the core will re-init rfkill->state from rfkill->get_state(), so it is not a serious problem at all (since the drive provides rfkill->get_state(). The reason it is recommended to always init the thing, is that if you later move to a purely event-driven rfkill interface, you won't break things. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
