Alexey Starikovskiy <aystarik@xxxxxxxxx> writes: > Ferenc Wagner wrote: > >> Alexey Starikovskiy <aystarik@xxxxxxxxx> writes: >> >>> Alexey Starikovskiy wrote: >>> >>>> On Fri, Nov 21, 2008 at 3:33 AM, Ferenc Wagner <wferi@xxxxxxx> wrote: >>>> >>>>> on my ThinkPad R50e the current_now reading seems something like 10 >>>>> times the actual value. [...] >>>> >>>> Good catch. ACPI battery interface report its state either in mW >>>> or in mA, and discharge rate in your case is reported in >>>> mW. power_supply interface does not have such a parameter, so >>>> current_now parameter is used for all cases. But in case of mW, >>>> reported discharge should be converted into mA. >>>> >>>> Please test the attached patch. >>> >>> This patch should be better -- no integer overflow. >> >> Thanks, this patch really fixes the issue (tried on 2.6.28-rc6). >> Hope to see it soon in Linus' tree! > > Great! Do you want to be memorized by "Tested-by:" line? Feel free to quote me if you see fit. >> Btw. that kernel gives me two ACPI warnings on boot: > > These issues are already known, and second even has a patch lurking > somewhere in this list... So no action required. Glad to hear. Thanks for the good work! -- Cheers, Feri. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
