Re: [PATCH 4/7] [sony-laptop] detect the ICH9 chipset as Type3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> In <1225705280-12775-5-git-send-email-malattia@xxxxxxxx> 
>>>>>	Mattia Dongili <malattia@xxxxxxxx> wrote:
>> From: ISHIKAWA Mutsumi <ishikawa@xxxxxxxxxxx>
>>
>> Signed-off-by: Mattia Dongili <malattia@xxxxxxxx>
>> ---
>>  drivers/misc/sony-laptop.c |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)

>> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
>> index c9e5651..19f3306 100644
>> --- a/drivers/misc/sony-laptop.c
>> +++ b/drivers/misc/sony-laptop.c
>> @@ -1589,6 +1589,13 @@ static void sony_pic_detect_device_type(struct sony_pic_dev *dev)
>>  		goto out;
>>  	}
 
>> +	pcidev = pci_get_device(PCI_VENDOR_ID_INTEL,
>> +			PCI_DEVICE_ID_INTEL_ICH9_1, NULL);
>> +	if (pcidev) {
>> +		dev->control = &spic_types[4];

 In patch [PATCH 1/7] [sony-laptop] merge Type4 into Type3,
type 3 and type 4 spic models are merged, and type 5 model
I added (of cause It is not problem, it is completly same as
type 4) are dropped.

 So I think spic_types[4] is invalid. This line should be as
bellow (Use Type 3 on ICH9_1 machines):

  dev->control = &spic_types[2];

>> +		goto out;
>> +	}
>> +
>>  	/* default */
>>  	dev->control = &spic_types[1];
 
>> -- 
>> 1.5.6.5


-- 
ISHIKAWA Mutsumi
  <ishikawa@xxxxxxxxxxx>, <ishikawa@xxxxxxx>, <ishikawa@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux