On Fri, 2008-10-31 at 10:58 +0800, Dave Airlie wrote: > > > > > > There is a build error with the attached config on the latest upstream > > > Linus kernel. > > > > > > CC [M] drivers/gpu/drm/i915/i915_suspend.o > > > drivers/gpu/drm/i915/i915_opregion.c: In function ‘intel_opregion_init’: > > > drivers/gpu/drm/i915/i915_opregion.c:340: error: implicit declaration of > > > function ‘register_acpi_notifier’ > > > drivers/gpu/drm/i915/i915_opregion.c: In function ‘intel_opregion_free’: > > > drivers/gpu/drm/i915/i915_opregion.c:361: error: implicit declaration of > > > function ‘unregister_acpi_notifier’ > > > make[4]: *** [drivers/gpu/drm/i915/i915_opregion.o] Error 1 > > > make[4]: *** Waiting for unfinished jobs.... > > > > > > Looks like the symbols are not defined when ACPI is not configured. > > > > > Yes, you're right. > > IGD OpeRegion depends on ACPI. > > I think we need to introduce a new kernel config option for > > IGD OpRegion support. > > > > cc matthew. > > The fix is queued for Linus already. > oops, I missed that email thread. thanks for the quick fix. :) -rui -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html