On Tue, 28 Oct 2008, Alexey Starikovskiy wrote: > Alan Jenkins wrote: >> <http://bugzilla.kernel.org/show_bug.cgi?id=11841> >> "plenty of line "ACPI: EC: non-query interrupt received, >> switching to interrupt mode" in dmesg" > Probably, it is better to make pr_debug(). Please don't do that. This code has had a lot of churn, and *regressions* as of lately, and sometimes we only notice these because we see those messages in the logs. Moving them to pr_debug() pretty much makes them utterly useless in a large number of the cases they could be of help. Besides, I very much doubt we will stop seing EC interrupt crappage. Not only our code is NOT good and resilient enough yet (if it were, there wouldn't be so many patches flying about it), the vendors are obviously getting this wrong at a fast rate. We need those messages. Rate-limit them, but don't hide them or move them to pr_debug, please. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
