Len, I really appreciate the quick reply and helpful advice. The reason why I chose that particular file to work on was two fold: First, the ACPI team seems to be very active and helpful as a project. Second, that file was by far the worst in a checkpatch compliance and could benefit the most from a little love. Thanks again for your time, and I will follow your advice going forward. Thanks, ~ Mike On Fri, Oct 17, 2008 at 3:52 PM, Len Brown <lenb@xxxxxxxxxx> wrote: > >> This patch fixes 100 errors and 8 warnings found by checkpatch against >> the asus_acpi.c file. >> >> It should apply cleanly to 2.6.27 and should not affect any code functionality. > > Hi Mike, > Welcome! > > I've applied your patch to the acpi-test tree. > > A couple of things to note for your next patch... > > This particular driver has a sub-maintainer, Corentin Chary, > as indicated in MAINTAINERS. Chary will probably either Ack or Nak > this patch in response to this note, but ideally you'd have sent > the patch to Chary in the first round. > > Note that this particular driver is suffering bit rot > b/c the plan is to eventually delete it in favor of > drivers/misc/asus-laptop.c. But I agree that as long > as it is still in the tree, it should undergo basic > maintenace, even if it never gets any new features. > > Also, best to avoid sending attachments if you can, because people > read comment and reply to plain text, and often don't open attachments. > From a patch application point of view, I can handle either, but > prefer plain text because I'm also a reviwer... > > ref: Documentation/SubmittingPatches > > thanks! > -Len > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
