Re: [RESEND] [PATCH] fujitsu-laptop: better handling of P8010 hotkey

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Len

> > diff -ruNp misc-linus/fujitsu-laptop.c misc-jmw/fujitsu-laptop.c
> 
> please see "SECTION 1" of Documentation/SubmittingPatches
> dunno if this is why your last one didn't apply.

Oops, sorry about that.  I was going to fix the diff paths before submitting
but in my haste to get it out I forgot about it.  In other words, the
failure to apply would have been due to the bogus local paths in the patch,
which were never meant to see the light of day.  Basically

  misc-linus -> linux-2.6-linus/drivers/misc
  misc-jmw   -> linux-2.6/drivers/misc

> re: Lindent
> please don't mix functional and style patches in the same patch,
> they should be in a series of multiple patches.  otherwise the
> style changes make it impossible to revivew the functional changes.

Yep.  Part of the problem in this case was that some of these changes came
from elsewhere.  They never separated it for me and at the time neither they
nor I had time to enforce the separation.  I'll be stricter next time. :-)

> anyway, this one is in the test tree now.

Thanks - I appreciate it.

> perhaps you can address dmitry's question?

Will do, but it might be a while before I have time to digest exactly what
it means and how to do it.  I'm going to be extremely short on time for
the next 3-4 weeks.

Regards
  jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux