Re: [patch 1/5] acpi: toshiba_acpi.c fix sparse signedness mismatch warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



applied.

thanks,
-Len

On Mon, 22 Sep 2008, akpm@xxxxxxxxxxxxxxxxxxxx wrote:

> From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> 
> set_bit expects unsigned int, and we start with a u32 anyway.
> drivers/acpi/toshiba_acpi.c:397:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:397:14:    expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:397:14:    got int *<noident>
> drivers/acpi/toshiba_acpi.c:399:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:399:14:    expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:399:14:    got int *<noident>
> drivers/acpi/toshiba_acpi.c:401:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:401:14:    expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:401:14:    got int *<noident>
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> Cc: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> Cc: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
> Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  drivers/acpi/toshiba_acpi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings drivers/acpi/toshiba_acpi.c
> --- a/drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings
> +++ a/drivers/acpi/toshiba_acpi.c
> @@ -548,7 +548,7 @@ static unsigned long write_video(const c
>  
>  	hci_read1(HCI_VIDEO_OUT, &video_out, &hci_result);
>  	if (hci_result == HCI_SUCCESS) {
> -		int new_video_out = video_out;
> +		unsigned int new_video_out = video_out;
>  		if (lcd_out != -1)
>  			_set_bit(&new_video_out, HCI_VIDEO_OUT_LCD, lcd_out);
>  		if (crt_out != -1)
> _
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux