Re: [PATCH 1/3] acer-wmi: Add rfkill support for wireless and bluetooth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Carlos,

On Wed, Oct 08, 2008 at 09:40:21PM +0100, Carlos Corbacho wrote:
> +
> +	rfkill_workqueue = create_singlethread_workqueue("rfkill_workqueue");
> +	if (!rfkill_workqueue) {
> +		if (has_cap(ACER_CAP_BLUETOOTH)) {
> +			kfree(bluetooth_rfkill->data);
> +			rfkill_unregister(bluetooth_rfkill);
> +		}
> +		kfree(wireless_rfkill->data);
> +		rfkill_unregister(wireless_rfkill);
> +		return -ENOMEM;
> +	}
> +	queue_delayed_work(rfkill_workqueue, &acer_rfkill_work, HZ);
> +

Do we really need a private workqueue here? acer_rfkill_work seems to
be a 'quickie' and so keventd should work pretty well here, shouldn't
it?

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux