On Wed, 2008-10-08 at 17:59 -0700, Zhang, Rui wrote: > On Wed, 2008-10-08 at 12:26 -0700, Matthew Garrett wrote: > > A patch went into the kernel earlier this year to ignore critical trip > > points that were below 0. > well, I think this patch is wrong. > a critical trip point below 0 Celsius doesn't mean it's invalid. > windows can work well on this laptop. > please look at: > http://bugzilla.kernel.org/show_bug.cgi?id=10686#c13 > IMO, we need to fix the ACPICA code first of all. > > Ming, what do you think of the patch in comment #15 and #16? We have a ACPICA patch at: http://git.acpica.org/repos/?p=acpica.git;a=commitdiff;h=ab557ef061978bd54baa05daca33ea16942629fa Method (_CRT, 0, Serialized) { If (LLess (OSYS, 0x07D6)) { If (LEqual (\_SB.TJ85, Zero)) { Return (Add (0x0AAC, Multiply (TPC, 0x0A))) } Else { Return (Add (0x0AAC, Multiply (TP85, 0x0A))) } } } Previously _CRT returns 0x07D6, now it returns 0 (predicate value of LLess) which matches windows behavior. So I felt it's better for the external interface (the driver) to check the return value (zero) and decide what to do. Thanks, Lin Ming -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
