On 08/10/08 16:25 -0400, Len Brown wrote: > > > On Fri, 26 Sep 2008, Jordan Crouse wrote: > > > Attached is a patch to support watchdog timers as described > > by the WDRT (Watch Dog Resource Table). This has been tested on > > the AMD SB600 chipset, but it should work for any chipset / BIOS > > that implements the WDRT table. > > > > I'm not in love with the name - but I couldn't think of anything > > better, so I'm open to suggestions. I have a limited number of > > systems that implement this interface, so I would be very happy > > to hear from other users, especially ones not using AMD chipsets. > > While this driver depends on ACPI, it actually isn't part of ACPI. > > Indeed, here is 100% of the ACPI spec support for this watchdog timer: > > "WDRT" Watchdog Resource Table Watchdog Timer Hardware Requirements for > Windows Server 2003 > http://www.microsoft.com/whdc/system/CEC/ > watchdog.mspx > > so while the driver uses ACPI to enumerate the device, > the device doesn't use any run-time ACPI support, > and the Windows spec above actually defines the hardware. > > > drivers/watchdog/acpiwdt.c > > I'm not wild about having the string "acpi" be part of the driver name, > config option, variable names etc. Maybe the spec above which actually > defines the timer would suggest a better name; or maybe simply > name it after its configuration table, wrdt.c? yeah - the string 'acpi' concerned as well. I didn't want to really call it win2k3wdt.c, though. :). > The spec URL should be in the driver comments or commit log, BTW. Will do. > I don't know who maintains /drivers/watchdog/, > but Wim Van Sebroeck has scribbled there the most recently, > and can probably weigh in on this. Yeah - I forgot to CC him on my previous email, and I forwarded it to him separately. > I searched my logs for WRDT and found only one, > and it does happen to be one with an Intel processor -- > though an nvidia chipset: > > http://bugzilla.kernel.org/show_bug.cgi?id=8950 > > so maybe Marc will be able to test the new driver? Sure - once Wim sends his comments, I'll ping him. Thanks. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
