On Fri, 2008-09-26 at 16:32 -0700, Jordan Crouse wrote: > This patch fixes the day of month math in acpi_system_write_alarm(). > The previous code assumed that there were 31 days in every month. > We caught this on June 30 when the month changed, but the system > stayed suspended waiting for June 31st. > > I know /proc/acpi/alarm is being deprecated, but its still there, > and I think as long as somebody can use it in anger, it should > correct. > agree. len, I think we should also apply this patch. Subject: ACPI: deprecate /proc/acpi/alarm /proc/acpi/alarm is deprecated. users can use /sys/class/rtc/rtcX/wakealarm instead. Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> --- drivers/acpi/Kconfig | 1 + drivers/acpi/sleep/proc.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6/drivers/acpi/sleep/proc.c =================================================================== --- linux-2.6.orig/drivers/acpi/sleep/proc.c +++ linux-2.6/drivers/acpi/sleep/proc.c @@ -78,7 +78,7 @@ acpi_system_write_sleep(struct file *fil } #endif /* CONFIG_ACPI_PROCFS */ -#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || !defined(CONFIG_X86) +#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE) || !defined(CONFIG_X86) || !define(CONFIG_ACPI_PROCFS) /* use /sys/class/rtc/rtcX/wakealarm instead; it's not ACPI-specific */ #else #define HAVE_ACPI_LEGACY_ALARM Index: linux-2.6/drivers/acpi/Kconfig =================================================================== --- linux-2.6.orig/drivers/acpi/Kconfig +++ linux-2.6/drivers/acpi/Kconfig @@ -60,6 +60,7 @@ config ACPI_PROCFS /proc/acpi/fadt (/sys/firmware/acpi/tables/FACP) /proc/acpi/debug_layer (/sys/module/acpi/parameters/debug_layer) /proc/acpi/debug_level (/sys/module/acpi/parameters/debug_level) + /proc/acpi/alarm (/sys/class/rtc/rtcX/wakealarm) This option has no effect on /proc/acpi/ files and functions which do not yet exist in /sys. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
