On Fri, 26 Sep 2008, Matthew Garrett wrote: > On Fri, Sep 26, 2008 at 02:49:53PM +0100, Alan Jenkins wrote: > > I was wrong to say that rfkill support was already in mainline. But it > > is introduced by Matthew's patch "eeepc-laptop: Use standard > > interfaces", as posted and reviewed on the linux-acpi list. I think > > this is a bad idea. Surely the whole point of rfkill is to let > > NetworkManager do power management *without* having to do different > > things for different laptops? > > No, it's to use allow the OS to control whatever mechanism the platform > provides for making the radio stop transmitting. The fact that this is, > uh, "interestingly" implemented on the Eee doesn't alter that. We should > just sort out the hotplug code... Almost correct. rfkill is for making the wireless transmitters stop EMITTING ENERGY. If one just stops sending data but, e.g., a carrier is still being transmitted, the device is NOT rfkill'ed... it is just silenced or something like that. Anyway, Matthew is quite right that it is well within rfkill's intended usage to power off and disconnect from the host bus the entire device in order to shut down energy emissions. However, if the hardware/platform can do it in a less heavy-handed way, that would be vastly prefered over kicking the device off the bus and powering it off, as far as rfkill is concered. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html