Re: [PATCH] ACPI: EC: do transaction from interrupt context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-09-25 at 18:52 +0100, Sitsofe Wheeler wrote:
> Alexey Starikovskiy wrote:
> > It is easier and faster to do transaction directly from interrupt context
> > rather than waking control thread.
> > Also, cleaner GPE storm avoidance is implemented.
Hi, Sitsofe
    I think that the problem on the asus-EEEPC can't be resolved really
by the Alexey's patch. IMO it is only lucky.
   In fact the main problem on Asus-EEEPC is related with the broken EC.
Before an EC notification event is processed, another EC notification
event arrives again.
   If EC driver check whether the SCI_EVT bit is set after processing
one EC notification event, the problem will be resolved. 
    http://bugzilla.kernel.org/show_bug.cgi?id=11089
    Alan Jenkins already sent a patch about how to fix the issue on the
Asus-EEEPC.
   
   But if the above patch is merged , maybe it will break some laptops.
On my laptop when issuing the query command, a non-zero query event is
returned but it can't be processed.(There is no corresponding ACPI _Qxx
object). At the same time the SCI_EVT bit won't be cleared. In such case
OS can't exit the function of acpi_ec_query_handler, which causes that
the acpid kernel thread can't work well.
   
   
> References: 	http://bugzilla.kernel.org/show_bug.cgi?id=9998
> > 		http://bugzilla.kernel.org/show_bug.cgi?id=10724
> > 		http://bugzilla.kernel.org/show_bug.cgi?id=10919
> > 		http://bugzilla.kernel.org/show_bug.cgi?id=11309
> > 		http://bugzilla.kernel.org/show_bug.cgi?id=11549
> > Signed-off-by: Alexey Starikovskiy <astarikovskiy@xxxxxxx>
> > ---
> 
> This resolves the slow hotkeys (e.g. brightness keys) that I see on my 
> EeePC 900.
> 
> Tested-by: Sitsofe Wheeler <sitsofe@xxxxxxxxx>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux