Harald, Thanks for picking up this driver -- I'm sure its users will be pleased to get it included in the kernel. I've got a couple of nitpicks I'd like you to fix before I can merge it... Please move the driver source to drivers/misc, where the other laptop drivers live. drivers/acpi/ is not for reverse-engineered platform drivers. Also, please consider changing the driver's name. toshiba_acpi is the oldtest, but least maintained driver of all the laptop platform drivers, so it isn't a good example. A better example is drivers/misc/*-laptop.c If this works on a broad range of panasonic, the panasonic-laptop panasonic make sense, else if it is more limited, then a more specific name would be better. Unclear what pcc stands for... Also, you can delete this line: -#include <linux/proc_fs.h> and this -/* definitions for /proc/ interface */ since you no longer have a /proc/interface. thanks, -Len ps. I'll keep your previous version in my test tree until you send along a new version, which hopefully we can merge into .28. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
