On Fri, 2008-09-05 at 10:26 +0800, Zhang Rui wrote:
> On Thu, 2008-09-04 at 16:35 +0400, Alexey Starikovskiy wrote:
> > Here is the same patch as attachment for your convenience.
> > Alexey Starikovskiy wrote:
> > > Hi Andy,
> > >
> > > I just uploaded patch for bugs 9998 and 10724, which solves the problem
> > > of interrupt storm more cleanly.
> > > Could you please add this patch to testing?
> > >
> > > Thanks,
> > > Alex.
> > >
> > >
> >
> + ec->t.command = 0;
> + if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
> + /* check if we received SCI during transaction */
> + ec_check_sci(ec, acpi_ec_read_status(ec));
> + /* it is safe to enable GPE outside of transaction */
> + acpi_enable_gpe(NULL, ec->gpe, ACPI_NOT_ISR);
> + } else if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags) &&
> + atomic_read(&ec->irq_count) >
> ACPI_EC_STORM_THRESHOLD)
> + pr_debug(PREFIX "GPE storm detected\n");
> + set_bit(EC_FLAGS_GPE_STORM, &ec->flags);
> + return 0;
> +}
>
> you will set the EC_FLAGS_GPE_STORM flag in every ec transaction.
> I don't think that's what you/we want. :)
What Rui said is right.
If the system is already switched to GPE mode, how to continue EC
transaction if there is no GPE interrupt confirmation in some EC
transaction? For example: on the laptops of bug 11428 & 8459. In fact
sometimes there is no EC GPE interrupt confirmation only for the last
step of EC transaction(OBF bit already indicates that data is ready but
there is no EC interrupt).
Thanks.
>
> thanks,
> rui
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
