Shaohua Li <shaohua.li@xxxxxxxxx> writes: > @@ -714,6 +802,7 @@ static DEVICE_ATTR(docked, S_IRUGO, show > static ssize_t show_flags(struct device *dev, > struct device_attribute *attr, char *buf) > { > + struct dock_station *dock_station = *((struct dock_station **)dev->platform_data); 80 characters? multiple occurrences. > > -postcore_initcall(dock_init); > +subsys_initcall(dock_init); Why so early? First that needs a comment. Also I don't understand it (especially since it's modular too) -Andi -- ak@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html