Shaohua Li <shaohua.li@xxxxxxxxx> writes:
> +static void dock_lock(struct dock_station *ds, int lock)
> +{
> + struct acpi_object_list arg_list;
> + union acpi_object arg;
> + acpi_status status;
> +
> + arg_list.count = 1;
> + arg_list.pointer = &arg;
> + arg.type = ACPI_TYPE_INTEGER;
> + arg.integer.value = !!lock;
> + status = acpi_evaluate_object(ds->handle, "_LCK", &arg_list, NULL);
> + if (ACPI_FAILURE(status) && status != AE_NOT_FOUND)
> + printk(KERN_WARNING PREFIX "%s device failed\n",
> + lock ? "Locking" : "Unlocking");
Please use two printks -- that makes the error message greppable.
Output the status and some identifier for the device? Otherwise
the user will have no clue what device failed.
-Andi
--
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
