On Mon, 2008-08-25 at 16:26 +0200, Joshua C. wrote: > I (and others with acer aspire 5050series laptops) have a broken bios > which resulted in kernel panic. Reported the bug > http://bugzilla.kernel.org/show_bug.cgi?id=10237 and > http://bugzilla.kernel.org/show_bug.cgi?id=8953 and a patch was > written about it. Can/When will this be merged upstream? Any arguments > against this as a hardware/platform solution? Linux can't work normally while Windows can work on such broken BIOS. Of course the issue is related with the broken BIOS. The _REG object of EC device is incorrect, which causes that EC device can't be initialized correctly. After this workaround patch is applied, Linux can also work. IMO this workaround patch is reasonable. Thanks. Yakui > Here is the patch from Zhao Yakui <yakui.zhao@xxxxxxxxx> > > Signed-off-by: Zhao Yakui <yakui.zhao@xxxxxxxxx> > Signed-off-by: Lin Ming <ming.m.lin@xxxxxxxxx> > > --- > drivers/acpi/ec.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > Index: linux-2.6/drivers/acpi/ec.c > =================================================================== > --- linux-2.6.orig/drivers/acpi/ec.c > +++ linux-2.6/drivers/acpi/ec.c > @@ -835,8 +835,19 @@ static int ec_install_handlers(struct ac > &acpi_ec_space_handler, > NULL, ec); > if (ACPI_FAILURE(status)) { > - acpi_remove_gpe_handler(NULL, ec->gpe, &acpi_ec_gpe_handler); > - return -ENODEV; > + if (status == AE_NOT_FOUND) { > + /* > + * Maybe OS fails in evaluating the _REG object. > + * The AE_NOT_FOUND error will be ignored and OS > + * continue to initialize EC. > + */ > + printk(KERN_ERR "Fail in evaluating _REG object." > + " It is broken BIOS.\n"); > + } else { > + acpi_remove_gpe_handler(NULL, ec->gpe, > + &acpi_ec_gpe_handler); > + return -ENODEV; > + } > } > > ec->handlers_installed = 1; > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
