On Thu, 2008-07-17 at 14:48 +0200, Andi Kleen wrote:
> As a general comment I wonder if this problem is really wide spread enough
> to deserve an own command line option or if that could be just done
> with quirks.
Our target is that no power state check becomes the default. But maybe
it is too aggressive before more tests.
When some people complain the similar problem, they can add the boot
option to confirm whether the problem can be fixed by the boot option.
If the problem can be fixed, we can add the laptop/desktop to DMI check
table firstly. After more tests, we expect that no power state check
becomes the default. In such case we can delete the DMI check table.
So now it is reasonable to deserve the command option.
>
> > --- linux-2.6.orig/drivers/acpi/power.c
> > +++ linux-2.6/drivers/acpi/power.c
> > @@ -54,6 +54,14 @@ ACPI_MODULE_NAME("power");
> > #define ACPI_POWER_RESOURCE_STATE_OFF 0x00
> > #define ACPI_POWER_RESOURCE_STATE_ON 0x01
> > #define ACPI_POWER_RESOURCE_STATE_UNKNOWN 0xFF
> > +
> > +#ifdef MODULE_PARAM_PREFIX
> > +#undef MODULE_PARAM_PREFIX
> > +#endif
>
> How can MODULE_PARAM_PREFIX be set here?
There exists the following macro definition in the
include/linux/moduleparam.h
#ifdef MODULE
#define MODULE_PARAM_PREFIX /* empty */
#else
#define MODULE_PARAM_PREFIX KBUILD_MODNAME "."
#endif
When this file is included, there will exist the macro defintion of
"MODULE_PARAM_PREFIX". So it is necessary to override it.
Thanks
Yakui
> -Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
