Re: [PATCH 5/9] fujitsu-laptop: fingers off backlight if video.ko

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > Perhaps there is a way to disable the dysfunctional backlight stuff in 
> > > video.ko but retain the ACPI video event handling?!
> > 
> > The problem with doing this is that it's only the platform-specific drivers
> > which have the knowledge as to whether this is necessary or not.  video.ko
> > would therefore have to query each loaded platform-specific module which
> > seems messy to me.  If video.ko was loaded before the relevant
> > platform-specific module it gets even messier.  I guess we could add a
> > video.ko function like acpi_video_backlight_disable() which platform modules
> > could call if they choose to handle the backlight.  However, this seems
> > suboptimal to since it means video.ko sets up a backlight interface only to
> > have to tear it down again soon after.  I guess it's no worse than setting
> > up a backlight interface which never gets used though.
> > 
> > The fundamental problem as I see at this point it is that the new
> > acpi_video_backlight_support() function returns true on Fujitsu S-series
> > laptops because the ACPI environment looks "right" from video.ko's point of
> > view.  However, it's clear that the desired registers/methods - although
> > present - are completely non-functional in these laptops so in reality
> > video.ko cannot handle the backlight in this case.  Unless video.ko
> > hooks into the Fujitsu-specific registers (which defeats the modularity of
> > hardware-specific modules) this won't change.
> 
> IMO, In this case, we should add a dmi check in video_detect.c and set
> acpi_backlight=vendor for this laptop, both before acpi video and
> fujitsu laptop driver is loaded.

That could work.  Keeping in mind that I'm yet to test the S7020 against
this patch though, what if it turns out that this problem affects most
Fujitsu laptops?  One wouldn't want dozens of model-specific checks in
video_detect.c, but I guess it may be possible to come up with a
sufficiently general DMI check that matched all such laptops.

Regards
  jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux