Hi there,
on the S6410 this prevents brightness control from working correctly.
the ACPI BIOS provides non-functional _BCM/_BQC so the video.ko is
registering backlight functions but does not work. Unfortunately not
loading video.ko isn't a solution since with
bc45b1d39a925b56796bebf8a397a0491489d85c the brightness keys are only
reported through video.ko.
Am Donnerstag, den 10.07.2008, 16:31 +0200 schrieb trenn@xxxxxxx:
> From: Thomas Renninger <trenn@xxxxxxx>
>
> ---
> drivers/misc/fujitsu-laptop.c | 26 ++++++++++++++------------
> 1 files changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/misc/fujitsu-laptop.c b/drivers/misc/fujitsu-laptop.c
> index 3601224..7306776 100644
> --- a/drivers/misc/fujitsu-laptop.c
> +++ b/drivers/misc/fujitsu-laptop.c
> @@ -963,16 +963,16 @@ static int __init fujitsu_init(void)
>
> /* Register backlight stuff */
>
> - fujitsu->bl_device =
> - backlight_device_register("fujitsu-laptop", NULL, NULL,
> - &fujitsubl_ops);
> - if (IS_ERR(fujitsu->bl_device))
> - return PTR_ERR(fujitsu->bl_device);
> -
> - max_brightness = fujitsu->max_brightness;
> -
> - fujitsu->bl_device->props.max_brightness = max_brightness - 1;
> - fujitsu->bl_device->props.brightness = fujitsu->brightness_level;
> + if (!acpi_video_backlight_support()) {
> + fujitsu->bl_device =
> + backlight_device_register("fujitsu-laptop", NULL, NULL,
> + &fujitsubl_ops);
> + if (IS_ERR(fujitsu->bl_device))
> + return PTR_ERR(fujitsu->bl_device);
> + max_brightness = fujitsu->max_brightness;
> + fujitsu->bl_device->props.max_brightness = max_brightness - 1;
> + fujitsu->bl_device->props.brightness = fujitsu->brightness_level;
> + }
>
> ret = platform_driver_register(&fujitsupf_driver);
> if (ret)
> @@ -1008,7 +1008,8 @@ fail_hotkey:
>
> fail_backlight:
>
> - backlight_device_unregister(fujitsu->bl_device);
> + if (fujitsu->bl_device)
> + backlight_device_unregister(fujitsu->bl_device);
>
> fail_platform_device2:
>
> @@ -1035,7 +1036,8 @@ static void __exit fujitsu_cleanup(void)
> &fujitsupf_attribute_group);
> platform_device_unregister(fujitsu->pf_device);
> platform_driver_unregister(&fujitsupf_driver);
> - backlight_device_unregister(fujitsu->bl_device);
> + if (fujitsu->bl_device)
> + backlight_device_unregister(fujitsu->bl_device);
>
> acpi_bus_unregister_driver(&acpi_fujitsu_driver);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
