Hi Matthew, On Thu, Jul 03, 2008 at 08:23:03PM +0100, Matthew Garrett wrote: > On Fri, Jul 04, 2008 at 01:35:42AM +0800, Harald Welte wrote: > > + > > +static int pcc_setkeycode(struct input_dev *dev, int scancode, int keycode) > > [...] > > You probably want to set_bit the input device here, and also clean up > any now-unused keycodes from there. I'd also suggest sending KEY_PROG1 > by default on the CPU throttle button - some users will find it easier > if it already generates a keycode. Other than that, looks good. Ok, I've added this. Thanks for noticing. I'm waiting on your feedback with regard to the /proc events vs. input event device and acpid handling. Once I am clear on this, I'll submit the hopefully final version that can be merged. Cheers, -- - Harald Welte <laforge@xxxxxxxxxxxx> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
Attachment:
signature.asc
Description: Digital signature
