Re: [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> utmisc.c needs to include asm-generic/bug.h for warn()/WARN() functions,
> but it should use WARN_ON() instead of warn_on_slowpath() since
> arches can provide their own implementation of WARN_ON(), which does
> not have to use/provide/implement warn_on_slowpath() at all.
> Just use the front door (WARN_ON).
> 
> linux-next-20080702/drivers/acpi/utilities/utmisc.c:1027: error: implicit declaration of function 'warn_on_slowpath'

On what architecture did you see that?

It might be be better to just provide it on all architectures supported
by ACPI (x86, ia64). I suppose it was ia64?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux