On Fri, 20 Jun 2008, Matthew Garrett wrote: > On Fri, Jun 20, 2008 at 02:52:30PM -0400, Len Brown wrote: > > What do you suggest for the best example of rfkill implementation > > that should be copied here? > > Either thinkpad-acpi or hp-wmi are pretty straightforward. I haven't sent the thinkpad-acpi rfkill implementation yet. And I have not reviewed hp-wmi to check if it is correct. If it uses the input polldev, I can give you 100% assurance that it is broken. You pretty much have to wait for my rfkill patches to get merged before you can do something right with rfkill and stuff like thinkpad-acpi that has read/write rfkill registers. Anyway, if anyone wants to look at the rfkill patches and the thinkpad-acpi rfkill implementation, which *is* straightforward like Matthew said, please refer to the thinkpad-acpi git trees at: git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git branches devel and rfkill. Note that both branches are in risk of being rebased/rewound, as they are tips of stgit branches. Get whatever you need from them, but don't base anything on them without talking to me first. rfkill, in particular, will have to be rebased to the wireless-testing tree soon. Also, if anyone wants/needs to be added to the cc list for the rfkill stuff I am trying to get merged (e.g. because you will also need it for your driver), drop me a note. I am planning to submit the thinkpad-acpi rfkill conversion only after the rfkill stuff gets merged in -next or some other tree, but real life is getting in the way. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
