Acked-by: Zhang Rui <rui.zhang@xxxxxxxxx>
On Tue, 2008-06-10 at 07:22 +0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: Bob Moore <robert.moore@xxxxxxxxx>
> Cc: Thomas Renninger <trenn@xxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> drivers/acpi/system.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff -puN drivers/acpi/system.c~acpi-use-memory_read_from_buffer
> drivers/acpi/system.c
> --- a/drivers/acpi/system.c~acpi-use-memory_read_from_buffer
> +++ a/drivers/acpi/system.c
> @@ -77,7 +77,6 @@ static ssize_t acpi_table_show(struct ko
> container_of(bin_attr, struct acpi_table_attr, attr);
> struct acpi_table_header *table_header = NULL;
> acpi_status status;
> - ssize_t ret_count = count;
>
> status =
> acpi_get_table(table_attr->name, table_attr->instance,
> @@ -85,18 +84,8 @@ static ssize_t acpi_table_show(struct ko
> if (ACPI_FAILURE(status))
> return -ENODEV;
>
> - if (offset >= table_header->length) {
> - ret_count = 0;
> - goto end;
> - }
> -
> - if (offset + ret_count > table_header->length)
> - ret_count = table_header->length - offset;
> -
> - memcpy(buf, ((char *)table_header) + offset, ret_count);
> -
> - end:
> - return ret_count;
> + return memory_read_from_buffer(buf, count, &offset,
> + table_header,
> table_header->length);
> }
>
> static void acpi_table_attr_init(struct acpi_table_attr *table_attr,
> _
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
