On Fri, Jun 06, 2008 at 01:23:08PM +0800, Shaohua Li wrote: > case ACPI_NOTIFY_EJECT_REQUEST: > ata_ehi_push_desc(ehi, "ACPI event"); > - > - if (!is_dock_event) > - break; > - > - /* undock event - immediate unplug */ > ata_acpi_detach_device(ap, dev); Ok, just to check that I've understood the other patches - this will only be called if the device has actually been removed, and not if you merely get an EJECT_REQUEST, right? An EJECT_REQUEST from a bay device should always just signal userspace, and never actually cause the device to be deleted. I don't really like the way that you're remapping event types inside the dock driver - it'd be cleaner if the per-driver handlers received ADD_DEVICE or REMOVE_DEVICE or something. Other than that, this looks basically fine. I'll try to test it in the next couple of days. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
