On 29-05-08 00:05, Bjorn Helgaas wrote:
On Wednesday 28 May 2008 02:58:47 pm Rene Herman wrote:
On 28-05-08 00:49, Bjorn Helgaas wrote:
When we encode IRQ resources, we should use the "shareable"
flag we got from _PRS rather than guessing based on the
IRQ trigger mode.
This is based on a patch by Tom Jaeger <ThJaeger@xxxxxxxxx>:
http://bugzilla.kernel.org/show_bug.cgi?id=9487#c32
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
Not-commented-on-by: Rene Herman <rene.herman@xxxxxxxxx>
Makes sense patchwise but one would expect that it wasn't that way to
start with due to perhaps some/many/most BIOSen not encoding the flag
correctly in _PRS. Don't know ACPI though...
I added IORESOURCE_IRQ_SHAREABLE recently:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c32928c579d88acd43981b59e86900da65f40762
and I just didn't notice these places at the time. If I had,
I would have made this change then. It's possible we could
trip over a BIOS issue, but I don't *think* that's why it's
been this way in the past.
Ah, I see. Was likely just a matter of originally not having a place to
stash it then (by the way, time flies; "recently" is almost two years
ago...)
Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
