Re: PNPACPI: use _CRS IRQ descriptor length for _SRS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bjorn Helgaas wrote:
[This fixes a long-standing parport PNPACPI bug, and it would
nice to have it in 2.6.26.]
I agree, especially since the ground work has already been laid in 1d5b285da1893b90507b081664ac27f1a8a3dc5b.
@@ -799,11 +802,14 @@ static void pnpacpi_encode_irq(struct pn
 		irq->sharable = ACPI_SHARED;
 	irq->interrupt_count = 1;
 	irq->interrupts[0] = p->start;
+	irq->descriptor_length = resource->data.irq.descriptor_length;
I don't understand the point of this line. Aren't irq->descriptor_length and resource->data.irq.descriptor_length the same thing?

Bjorn, while we're on the subject, could you have a look at http://bugzilla.kernel.org/show_bug.cgi?id=9487#c32 ? I've noticed that you've already fixed the third point there; the other two points may well be irrelevant or never occur in practice, but then they could be the sort of thing that costs somebody hours of debugging time.

Thanks,
Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux