On Thu 22. May - 14:33:01, Shaohua Li wrote: > docking station releted fixes > patch 1, 2: fix > patch 3, 4, 5: merge bay driver into dock driver. dock driver can handle > battery and bay. > patch 6, 7: make libata work with dock driver > patch 8: cleanup > > I tested in a T43 with bay and battery hotplug, please review. Have you seen this patch? Are those changes incorporated? http://marc.info/?l=linux-acpi&m=121129188316720&w=2 What are the advantages against just letting libata-acpi doing the _EJ0? I gave your patch set a short test and have encountered the following issues: 1. No uevent on a ACPI_NOTIFY_EJECT_REQUEST giving no chance to userspace to clean up filesystems etc. 2. When a bay device is removed, the device (e.g. /dev/sr0) stays visible for userspace, even after accessing it and getting a rescan and 'klogd: ata5.00: disabled' Regards, Holger -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
