On Friday, May 09, 2008 2:44 pm Rafael J. Wysocki wrote: > Okay, what about this: > > --- > From: Rafael J. Wysocki <rjw@xxxxxxx> > > The new suspend and hibernation callbacks introduced with > 'struct pm_ops' and 'struct pm_ext_ops' do not take a > pm_message_t argument, so the drivers using them will not be able > to use pci_choose_state() in its present form. For this reason, > introduce a new function, pci_choose_and_set_state(), playing the > role of pci_choose_state() combined with pci_set_power_state() and > allowing the driver to put the device into a power state chosen by > the platform. Yeah, that looks pretty good. The name is long but I can't think of a better one offhand. Can you also update Documentation/power/pci.txt with the latest best practices? I wonder if we should do a pass through the drivers converting them to this interface as well... Thanks, Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
