Re: [PATCH 091/171] ACPI: GPE enabling should happen after EC installation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 30 Apr 2008, Carlos Corbacho wrote:
> On Wednesday 30 April 2008 11:25:34 Zhao Yakui wrote:
> > On Tue, 2008-04-29 at 04:44 -0400, Len Brown wrote:
> > > From: Alexey Starikovskiy <astarikovskiy@xxxxxxx>
> > >
> > > GPE could try to access EC region, so should not be enabled before
> > > EC is installed
> >
> > It is caused by broken bios if GPE method tries to access EC region
> > before EC is initialized correctly. It is more appropriate to fix this
> > issue by upgrading bios rather than by the patch.
> > And this patch will cause some potential problems.
> 
> 1) Does the BIOS in question work under Windows?
> 2) Does the system in question require a BIOS upgrade under Windows for this 
> issue?
> 
> If the answer to both of those is 'no', then the answer is that it's a Linux 
> bug, and a patch of some description is appropriate.

3) Did the vendor issue an O.S. "driver workaround"?  If so, it means we
add a *quirk*, and not that we hose ACPI for everyone else.

> Just because there are crappy BIOS's out there, and we'd rather not put in 
> nasty fixes, doesn't mean that we shouldn't.

But it means we need to limit the damage these nasty fixes can do to
others.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux