On Mon, 21 Apr 2008, Thomas Renninger wrote: > - IIRC the physical HW address to switch to C2/C3 is provided through > the FADT table. > - For "1SET*" ThinkPad BIOSes, C-states are blacklisted as they freeze > if C-states are invoked (see drivers/acpi/processor_idle.c). > - This patch chooses an alternate FADT table if the content of the > other table differs (either the one pointed to by XSDT or RSDT). > - The machine which shows different contents of FADTs is a R50e: > http://bugzilla.kernel.org/show_bug.cgi?id=8246 > - While the bug was opened because of slow booting (due to wrong HW > addresses accessed?), I could imagine Yakui has found the root cause > why C-states didn't work on some older ThinkPads. > > -> It should be tested whether ThinkPads which have C-states blacklisted > do work with the other FADT and the blacklist in > drivers/acpi/processor_idle.c can be removed or what I meant, it can be > moved/reused for a kind of force_rsdt flag... > > All this is theory and needs testing... > I can try to find one of the older ThinkPad models... This is really interesting, and I am sure that should you provide patches and instructions that users can easily apply to, say, 2.6.24.y, in an email to the linux-thinkpad ML describing what benefits should testing could have, you'll get some good testers. I've easily gotten a lot of the testing I needed done in the past by asking for help there. I have added linux-thinkpad to the CC, but I seriously recommend that you start a new thread there with a much more clear subject if you decide to ask for testers. It'd be good to also have a list of the thinkpad models currently blacklisted for functions that depend on the FADT, and thus which could get these functions back if the select-the-proper-FADT patch works on them. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
