From: Li Zefan <lizf@xxxxxxxxxxxxxx> We should check *resource != NULL rather than resource != NULL, which will be always true. Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx> Acked-by: Zhao Yakui <yakui.zhao@xxxxxxxxx> Cc: Len Brown <lenb@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/acpi/power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/acpi/power.c~acpi-check-a-return-value-correctly-in-acpi_power_get_context drivers/acpi/power.c --- a/drivers/acpi/power.c~acpi-check-a-return-value-correctly-in-acpi_power_get_context +++ a/drivers/acpi/power.c @@ -121,7 +121,7 @@ acpi_power_get_context(acpi_handle handl } *resource = acpi_driver_data(device); - if (!resource) + if (!*resource) return -ENODEV; return 0; _ -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html