On Wed, Mar 12, 2025 at 02:04:51PM -0400, Adam Young wrote: > The XGene patch did not apply on top of Linus's current tree. The other > patches applied OK. > Yes Guenter had mentioned it in his review. I have it rebased locally [1] but yet to push out v3 on the list. > I only had to make one modification to my patch to remove the call to > ‘pcc_mbox_ioremap’, as it is performed in the pcc_mbox_request_channel call > instead. With that change, my driver continues to work. I will submit > another version here shortly. > Nice, I wasn't aware of the Ampere driver using ioremap. Is it posted on the list ? Or are you saying you will post it soon. Thanks for testing. Please provide tested-by for patch 1-8 if you are happy with it. > I like the direction that this change is pushing, making the mailbox layer > the owner for other drivers. > Yes it was long due. I had changes in my WIP but was away when you changes got merged. Otherwise I would have asked you to do some of the changes in this series. My bad, couldn't review your patches unfortunately. -- Regards, Sudeep [1] ihttps://git.kernel.org/sudeep.holla/h/b4/pcc_fixes_updates