Moore, Robert wrote:
We use acpi_native_uint for things like array indexes so it goes 32/64
without warnings (lint or otherwise).
However,
typedef UINT32 ACPI_NATIVE_UINT;
should get converted to
typedef u32 acpi_native_uint;
Well, "unsigned int" is supposed to be of native length. u32 is not going to be of
native length on 64 bits.
What kind of warning do you avoid?
I don't know any checker who does not accept int/unsigned int as array index...
Regards,
Alex.
during the linuxiztion, I think
-----Original Message-----
From: Alexey Starikovskiy [mailto:aystarik@xxxxxxxxx]
Sent: Tuesday, April 15, 2008 1:36 AM
To: Len Brown
Cc: linux-acpi@xxxxxxxxxxxxxxx; Moore, Robert; Alexey Starikovskiy
Subject: Re: [PATCH 65/73] ACPICA: Fix for extraneous debug message for
packages
Len Brown wrote:
From: Len Brown <len.brown@xxxxxxxxx>
drivers/acpi/dispatcher/dsobject.c:499: warning: format '%X' expects
type
'unsigned int', but argument 4 has type 'acpi_native_uint'
drivers/acpi/dispatcher/dsobject.c:507: warning: format '%X' expects
type
'unsigned int', but argument 7 has type 'acpi_native_uint'
Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
---
drivers/acpi/dispatcher/dsobject.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/dispatcher/dsobject.c
b/drivers/acpi/dispatcher/dsobject.c
index 5184278..bdef2f0 100644
--- a/drivers/acpi/dispatcher/dsobject.c
+++ b/drivers/acpi/dispatcher/dsobject.c
@@ -373,7 +373,7 @@ acpi_ds_build_internal_package_obj(struct
acpi_walk_state *walk_state,
union acpi_parse_object *parent;
union acpi_operand_object *obj_desc = NULL;
acpi_status status = AE_OK;
- acpi_native_uint i;
+ u32 i;
why not just unsigned ?
u16 index;
u16 reference_count;
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
