On Tue, Mar 4, 2025 at 3:45 PM Shen, Yijun <Yijun.Shen@xxxxxxxx> wrote: > > > Internal Use - Confidential > > -----Original Message----- > > From: Mario Limonciello <superm1@xxxxxxxxxx> > > Sent: Tuesday, March 4, 2025 5:27 AM > > To: Limonciello, Mario <mario.limonciello@xxxxxxx>; rafael@xxxxxxxxxx > > Cc: Shen, Yijun <Yijun_Shen@xxxxxxxx>; Richard.Gong > > <Richard.Gong@xxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx > > Subject: [PATCH] ACPI: button: Install notifier for system events as well > > > > > > [EXTERNAL EMAIL] > > > > From: Mario Limonciello <mario.limonciello@xxxxxxx> > > > > On some systems when the system is put to sleep pressing the ACPI power > > button will cause the EC SCI to try to wake the system by a Notify(DEV, 0x2) > > with an intention to wake the system up from suspend. > > > > This behavior matches the ACPI specification in ACPI 6.4 section > > 4.8.3.1.1.2 which describes that the AML handler would generate a Notify() > > with a code of 0x2 to indicate it was responsible for waking the system. > > > > This currently doesn't work because acpi_button_add() only configured > > `ACPI_DEVICE_NOTIFY` which means that device handler notifications > > 0x80 through 0xFF are handled. > > > > To fix the wakeups on such systems, adjust the ACPI button handler to use > > `ACPI_ALL_NOTIFY` which will handle all events 0x00 through 0x7F. > > > > Reported-by: Yijun Shen <Yijun.Shen@xxxxxxxx> > > Tested-by: Richard Gong <Richard.Gong@xxxxxxx> > > Link: > > https://urldefense.com/v3/__https://uefi.org/htmlspecs/ACPI_Spec_6_4_html > > /04_ACPI_Hardware_Specification/ACPI_Hardware_Specification.html?highlig > > ht=0x2*control-method-power-button__;Iw!!LpKI!m8bmT5JUyck9Q0BMUA- > > LmC5MXTEXFeJ1nmcNGIhJ4AWCQ7XMUR_UqxaxBor674mhMk53MkwkXqT1a > > cTF$ [uefi[.]org] > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > > Verified the patch on the issued system, the issue is gone. > > Tested-by: Yijun Shen <Yijun_Shen@xxxxxxxx> Applied as 6.15 material, thanks!
