On Mon, Mar 03, 2025 at 01:34:49PM +0200, Matti Vaittinen wrote: > We can avoid open-coding the loop construct which counts firmware child > nodes with a specific name by using the newly added > device_get_child_node_count_named(). > > The gianfar driver has such open-coded loop. Replace it with the > device_get_child_node_count_named(). ... > It's fair to tell the pros and cons of this patch. > The simplification is there, but it's not a big one. It comes with a cost > of getting the property.h included in this driver which currently uses > exclusively the of_* APIs. I think it's a good step to the right direction. We might convert the rest (at least I don't see much impediments while briefly looking into the code). ... What about the second loop (in gfar_of_init)? I mean perhaps we want to have fwnode_for_each_named_child_node() and its device variant that may be also reused in the IIO code and here. -- With Best Regards, Andy Shevchenko
