Hi Mario, thanks for your patch! On Wed, Feb 19, 2025 at 3:54 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote: > From: Mario Limonciello <mario.limonciello@xxxxxxx> > > During suspend the pinctrl_amd driver disables the interrupts for > any GPIOs that are not marked as wake sources. > > This however does not prevent them from changing the wake status > bit during suspend, it just stops the system from waking. > > If the system wakes from hardware sleep for another reason (such > as plugging in the AC adapter) this wake bits might be active. > > This could potentially cause problems with going back to hardware > sleep. Add an extra debugging message when PM debugging is enabled > to help identify if this is happening. > > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3929 > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> I don't understand the ACPI part of this patch, and I think I was not even CC:ed on 1/2 so I haven't seen it. Anyway: Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> if you want to apply it in the ACPI tree. Yours, Linus Walleij