Hello Rafael & Viresh, There are two things about this patchset I would like your advice on: 1. Pierre and I have discussed about whether or not to show auto_act_window and energy_performance_preference_val when auto_select is disabled [1]. It seems like whether to show these two files has their own points. We'd like to ask for some advice. 2. In intel_pstate driver, there is a file named "energy_performance_preference", which accepts not only raw value but also a few string arguments and converts them to integers. But I think this implementation is not really nice and prefer not to follow it [2]. To distinguish it, I named the file in cppc_cpufreq "energy_performance_preference_val" instead of "energy_performance_preference". Should I follow the implementation of intel_pstate? Looking forward to your reply! Relevant discussion: [1] https://lore.kernel.org/all/522721da-1a5c-439c-96a8-d0300dd0f906@xxxxxxxxxx/ [2] https://lore.kernel.org/all/0c511da2-6a4a-4fa2-9d82-da45d1afe346@xxxxxxxxxx/
