On Mon, Dec 16, 2024 at 7:50 PM jack Bourke-Mckenna <jackbourkemckenna@xxxxxxxxx> wrote: > > Hi Rafael J. Wysocki and ACPI maintainers, > > I wanted to ask about improving Linux support for the Lenovo ThinkPad > E14 Type 20RA. Right now, this laptop defaults to the "deep" sleep > state (S3), but it has resume issues. On the other hand, "s2idle" > works reliably, and users can enable it manually with the > mem_sleep_default=s2idle kernel parameter. > > Would it make sense to make a modification to the ACP DMI table to > set "s2idle" as the default sleep mode for this laptop? It seems like > it would fix the suspend/resume problems out of the box without users > needing to tweak anything manually(this was a huge pain to debug). Yes, if it works. > Does this seem like the right way to address the issue? I’m happy to > put together a patch and include logs showing the problem if you think > it’s worth pursuing. Or is it likely to be ignored because the E14 has > a relatively small user base? It won't be ignored, but if it is applied and some other users report a problem with it, it will need to be reverted. Thanks!