>-----Original Message----- >From: Shiju Jose <shiju.jose@xxxxxxxxxx> >Sent: 09 December 2024 14:28 >To: Dan Williams <dan.j.williams@xxxxxxxxx>; linux-edac@xxxxxxxxxxxxxxx; >linux-cxl@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; >linux-kernel@xxxxxxxxxxxxxxx >Cc: bp@xxxxxxxxx; tony.luck@xxxxxxxxx; rafael@xxxxxxxxxx; lenb@xxxxxxxxxx; >mchehab@xxxxxxxxxx; dave@xxxxxxxxxxxx; Jonathan Cameron ><jonathan.cameron@xxxxxxxxxx>; dave.jiang@xxxxxxxxx; >alison.schofield@xxxxxxxxx; vishal.l.verma@xxxxxxxxx; ira.weiny@xxxxxxxxx; >david@xxxxxxxxxx; Vilas.Sridharan@xxxxxxx; leo.duran@xxxxxxx; >Yazen.Ghannam@xxxxxxx; rientjes@xxxxxxxxxx; jiaqiyan@xxxxxxxxxx; >Jon.Grimm@xxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; >naoya.horiguchi@xxxxxxx; james.morse@xxxxxxx; jthoughton@xxxxxxxxxx; >somasundaram.a@xxxxxxx; erdemaktas@xxxxxxxxxx; pgonda@xxxxxxxxxx; >duenwen@xxxxxxxxxx; gthelen@xxxxxxxxxx; >wschwartz@xxxxxxxxxxxxxxxxxxx; dferguson@xxxxxxxxxxxxxxxxxxx; >wbs@xxxxxxxxxxxxxxxxxxxxxx; nifan.cxl@xxxxxxxxx; tanxiaofei ><tanxiaofei@xxxxxxxxxx>; Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; Roberto >Sassu <roberto.sassu@xxxxxxxxxx>; kangkang.shen@xxxxxxxxxxxxx; >wanghuiqiang <wanghuiqiang@xxxxxxxxxx>; Linuxarm ><linuxarm@xxxxxxxxxx> >Subject: RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for >kernel usage > >>-----Original Message----- >>From: Dan Williams <dan.j.williams@xxxxxxxxx> >>Sent: 06 December 2024 21:41 >>To: Shiju Jose <shiju.jose@xxxxxxxxxx>; linux-edac@xxxxxxxxxxxxxxx; >>linux- cxl@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; >>linux-mm@xxxxxxxxx; linux- kernel@xxxxxxxxxxxxxxx >>Cc: bp@xxxxxxxxx; tony.luck@xxxxxxxxx; rafael@xxxxxxxxxx; >>lenb@xxxxxxxxxx; mchehab@xxxxxxxxxx; dan.j.williams@xxxxxxxxx; >>dave@xxxxxxxxxxxx; Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>; >>dave.jiang@xxxxxxxxx; alison.schofield@xxxxxxxxx; >>vishal.l.verma@xxxxxxxxx; ira.weiny@xxxxxxxxx; david@xxxxxxxxxx; >>Vilas.Sridharan@xxxxxxx; leo.duran@xxxxxxx; Yazen.Ghannam@xxxxxxx; >>rientjes@xxxxxxxxxx; jiaqiyan@xxxxxxxxxx; Jon.Grimm@xxxxxxx; >>dave.hansen@xxxxxxxxxxxxxxx; naoya.horiguchi@xxxxxxx; >>james.morse@xxxxxxx; jthoughton@xxxxxxxxxx; >somasundaram.a@xxxxxxx; >>erdemaktas@xxxxxxxxxx; pgonda@xxxxxxxxxx; duenwen@xxxxxxxxxx; >>gthelen@xxxxxxxxxx; wschwartz@xxxxxxxxxxxxxxxxxxx; >>dferguson@xxxxxxxxxxxxxxxxxxx; wbs@xxxxxxxxxxxxxxxxxxxxxx; >>nifan.cxl@xxxxxxxxx; tanxiaofei <tanxiaofei@xxxxxxxxxx>; Zengtao (B) >><prime.zeng@xxxxxxxxxxxxx>; Roberto Sassu <roberto.sassu@xxxxxxxxxx>; >>kangkang.shen@xxxxxxxxxxxxx; wanghuiqiang <wanghuiqiang@xxxxxxxxxx>; >>Linuxarm <linuxarm@xxxxxxxxxx>; Shiju Jose <shiju.jose@xxxxxxxxxx> >>Subject: Re: [PATCH v17 05/18] cxl: Add Get Supported Features command >>for kernel usage >> >>shiju.jose@ wrote: >>> From: Dave Jiang <dave.jiang@xxxxxxxxx> >>> >>> CXL spec r3.1 8.2.9.6.1 Get Supported Features (Opcode 0500h) The >>> command retrieve the list of supported device-specific features >>> (identified by UUID) and general information about each Feature. >>> >>> The driver will retrieve the feature entries in order to make checks >>> and provide information for the Get Feature and Set Feature command. >>> One of the main piece of information retrieved are the effects a Set >>> Feature command would have for a particular feature. >>> >>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> >>> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> >>> Co-developed-by: Shiju Jose <shiju.jose@xxxxxxxxxx> >>> Signed-off-by: Shiju Jose <shiju.jose@xxxxxxxxxx> >>> --- >>> drivers/cxl/core/mbox.c | 179 +++++++++++++++++++++++++++++++++++ >>> drivers/cxl/cxlmem.h | 44 +++++++++ >>> drivers/cxl/pci.c | 4 + >>> include/cxl/mailbox.h | 4 + >>> include/uapi/linux/cxl_mem.h | 1 + >>> 5 files changed, 232 insertions(+) >> >>Hi Shiju, >> >>So I commented yesterday on this patch that is also duplicated in >>Dave's series have a merge order ordering plan to propose. > >Hi Dan, > >Thanks for the suggestions. >I tested your suggestions for CXL features commands in the fwctl series, in the >EDAC CXL features setup, as replied. Please find updated patches for your suggestions are shared here. https://github.com/shijujose4/linux/tree/edac-enhancement-ras-features_for_v18 However next version (v18) of EDAC series will send after receiving feedbacks from Borislav on v17 EDAC patches. >> >>> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index [...] > Thanks, Shiju
