Em Tue, 10 Dec 2024 19:55:57 +0000 Ricardo Ribalda <ribalda@xxxxxxxxxxxx> escreveu: > We want to be able to compile_test the ipu6 driver in situations with > !ACPI. > > In order to do this we had to add some conditional #ifs, which lead to > false positives on the static analysers. > > Let's implement some helpers when !ACPI in the acpi headers to make the > code more easier to maintain. > > We can land the first patch of this series ASAP to fix the current > smatch warning. > > To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > To: Rafael J. Wysocki <rafael@xxxxxxxxxx> > To: Len Brown <lenb@xxxxxxxxxx> > To: Robert Moore <robert.moore@xxxxxxxxx> > To: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: linux-acpi@xxxxxxxxxxxxxxx > Cc: acpica-devel@xxxxxxxxxxxxxxx > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > > Changes in v3: > - Prefer static inlines to macros (Thanks Rafael). > - Link to v2: https://lore.kernel.org/r/20241122-fix-ipu-v2-0-bba65856e9ff@xxxxxxxxxxxx > > Changes in v2: > - Add helpers in acpi to avoid conditional compilation > - Link to v1: https://lore.kernel.org/r/20241122-fix-ipu-v1-1-246e254cb77c@xxxxxxxxxxxx > > --- > Ricardo Ribalda (7): > media: ipu-bridge: Fix warning when !ACPI Not needed, as patch 7 will revert it. > ACPI: bus: implement for_each_acpi_dev_match when !ACPI > ACPI: bus: implement acpi_get_physical_device_location when !ACPI > ACPI: header: implement acpi_device_handle when !ACPI > ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI > ACPI: bus: implement acpi_device_hid when !ACPI patches 2-6 look ok to me, but I'll leave it to ACPI maintainers to review. From my side: Acked-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > media: ipu-bridge: Remove unneeded conditional compilations See my review with my R-B. As the crucial changes are at ACPI side, I'm assuming that this will be merged via ACPI tree. Regards, Maur Thanks, Mauro
