Re: [PATCH v6 05/22] ACPI: platform_profile: Pass the profile handler into platform_profile_notify()

[Armin Wolf <W_Armin@xxxxxx>]

Am 09.11.24 um 05:41 schrieb Mario Limonciello:

> The profile handler will be used to notify the appropriate class
> devices.

Reviewed-by: Armin Wolf <W_Armin@xxxxxx>

> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
>   drivers/acpi/platform_profile.c       |  2 +-
>   drivers/platform/x86/acer-wmi.c       |  2 +-
>   drivers/platform/x86/asus-wmi.c       |  4 ++--
>   drivers/platform/x86/ideapad-laptop.c |  2 +-
>   drivers/platform/x86/thinkpad_acpi.c  | 14 +++++++-------
>   include/linux/platform_profile.h      |  2 +-
>   6 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index c24744da20916..927a2f7456c9a 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -128,7 +128,7 @@ static const struct attribute_group platform_profile_group = {
>   	.attrs = platform_profile_attrs
>   };
>
> -void platform_profile_notify(void)
> +void platform_profile_notify(struct platform_profile_handler *pprof)
>   {
>   	if (!cur_profile)
>   		return;
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index b12965d9fcdb7..0018818258070 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1988,7 +1988,7 @@ static int acer_thermal_profile_change(void)
>   		if (tp != ACER_PREDATOR_V4_THERMAL_PROFILE_TURBO_WMI)
>   			last_non_turbo_profile = tp;
>
> -		platform_profile_notify();
> +		platform_profile_notify(&platform_profile_handler);
>   	}
>
>   	return 0;
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 0750e2fe65325..2a8d789ee05cf 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -3754,7 +3754,7 @@ static int throttle_thermal_policy_switch_next(struct asus_wmi *asus)
>   	 * Ensure that platform_profile updates userspace with the change to ensure
>   	 * that platform_profile and throttle_thermal_policy_mode are in sync.
>   	 */
> -	platform_profile_notify();
> +	platform_profile_notify(&asus->platform_profile_handler);
>
>   	return 0;
>   }
> @@ -3793,7 +3793,7 @@ static ssize_t throttle_thermal_policy_store(struct device *dev,
>   	 * Ensure that platform_profile updates userspace with the change to ensure
>   	 * that platform_profile and throttle_thermal_policy_mode are in sync.
>   	 */
> -	platform_profile_notify();
> +	platform_profile_notify(&asus->platform_profile_handler);
>
>   	return count;
>   }
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 80797c6ae8b0b..79c65c24b433a 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1041,7 +1041,7 @@ static void dytc_profile_refresh(struct ideapad_private *priv)
>
>   	if (profile != priv->dytc->current_profile) {
>   		priv->dytc->current_profile = profile;
> -		platform_profile_notify();
> +		platform_profile_notify(&priv->dytc->pprof);
>   	}
>   }
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 13798c6d5fcf3..8539cac042be8 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -10516,6 +10516,12 @@ static int dytc_profile_set(struct platform_profile_handler *pprof,
>   	return err;
>   }
>
> +static struct platform_profile_handler dytc_profile = {
> +	.name = "thinkpad-acpi",
> +	.profile_get = dytc_profile_get,
> +	.profile_set = dytc_profile_set,
> +};
> +
>   static void dytc_profile_refresh(void)
>   {
>   	enum platform_profile_option profile;
> @@ -10544,16 +10550,10 @@ static void dytc_profile_refresh(void)
>   	err = convert_dytc_to_profile(funcmode, perfmode, &profile);
>   	if (!err && profile != dytc_current_profile) {
>   		dytc_current_profile = profile;
> -		platform_profile_notify();
> +		platform_profile_notify(&dytc_profile);
>   	}
>   }
>
> -static struct platform_profile_handler dytc_profile = {
> -	.name = "thinkpad-acpi",
> -	.profile_get = dytc_profile_get,
> -	.profile_set = dytc_profile_set,
> -};
> -
>   static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
>   {
>   	int err, output;
> diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
> index bcaf3aa39160f..8ec0b8da56db5 100644
> --- a/include/linux/platform_profile.h
> +++ b/include/linux/platform_profile.h
> @@ -39,6 +39,6 @@ struct platform_profile_handler {
>   int platform_profile_register(struct platform_profile_handler *pprof);
>   int platform_profile_remove(struct platform_profile_handler *pprof);
>   int platform_profile_cycle(void);
> -void platform_profile_notify(void);
> +void platform_profile_notify(struct platform_profile_handler *pprof);
>
>   #endif  /*_PLATFORM_PROFILE_H_*/