On Wed, Nov 13, 2024 at 08:27:35AM -0700, Dave Jiang wrote: > I'm actually looking for recommendation on what the proper one is. The > handler is expected to offline the aliased address of the reported MCE if > there is one. Well, MCE_PRIO_EARLY will emit a trace record so that if you have error events consumers like rasdaemon, it'll get that error record for reporting etc. MCE_PRIO_UC calls memory_failure() on the error and thus offlines the page. Functionality which you're partly replicating in your notifier. And since you wanna do the same thing, why are you even adding a new priority instead of using MCE_PRIO_UC? amdgpu_bad_page_notifier() uses that same prio because it does a similar thing. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette