Re: [PATCH] acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+Cc Catalin and Will

On 2024/8/30 0:24, Sudeep Holla wrote:
On Thu, Aug 29, 2024 at 05:17:44PM +0100, Sudeep Holla wrote:
On Tue, Aug 27, 2024 at 01:12:39PM +0300, Aleksandr Mishin wrote:
In case of error in gtdt_parse_timer_block() invalid 'gtdt_frame'
will be used in 'do {} while (i-- >= 0 && gtdt_frame--);' statement block
because do{} block will be executed even if 'i == 0'.

Adjust error handling procedure by replacing 'i-- >= 0' with 'i-- > 0'.

Found by Linux Verification Center (linuxtesting.org) with SVACE.


(For some reason I don't see the original email in my inbox, might have
got blocked 🙁). Anyways LGTM,

Acked-by: Aleksandr Mishin <amishin@xxxxxxxxxx>

Sorry I messed up, I meant

Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>

Catalin, this is a fix, and was acked by Sudeep and me, could you
merge it for next release cycle?

Thanks
Hanjun




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux