Re: [PATCH v4 05/20] ACPI: platform_profile: Move sanity check out of the mutex

[Armin Wolf <W_Armin@xxxxxx>]

Am 05.11.24 um 16:33 schrieb Mario Limonciello:

> The sanity check that the platform handler had choices set doesn't
> need the mutex taken.  Move it to earlier in the registration.

Reviewed-by: Armin Wolf <W_Armin@xxxxxx>

> Tested-by: Matthew Schwartz <matthew.schwartz@xxxxxxxxx>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
>   drivers/acpi/platform_profile.c | 13 ++++++-------
>   1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index c76b8e3fdcde6..4e8a155589c21 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -179,6 +179,12 @@ int platform_profile_register(struct platform_profile_handler *pprof)
>   {
>   	int err;
>
> +	/* Sanity check the profile handler */
> +	if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
> +	    !pprof->profile_set || !pprof->profile_get) {
> +		pr_err("platform_profile: handler is invalid\n");
> +		return -EINVAL;
> +	}
>   	if (!pprof->dev) {
>   		pr_err("platform_profile: handler device is not set\n");
>   		return -EINVAL;
> @@ -191,13 +197,6 @@ int platform_profile_register(struct platform_profile_handler *pprof)
>   		return -EEXIST;
>   	}
>
> -	/* Sanity check the profile handler field are set */
> -	if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
> -		!pprof->profile_set || !pprof->profile_get) {
> -		mutex_unlock(&profile_lock);
> -		return -EINVAL;
> -	}
> -
>   	err = sysfs_create_group(acpi_kobj, &platform_profile_group);
>   	if (err) {
>   		mutex_unlock(&profile_lock);