On Thu, Oct 31, 2024, at 12:09 AM, Mario Limonciello wrote:
> The sanity check that the platform handler had choices set doesn't
> need the mutex taken. Move it to earlier in the registration.
>
> Tested-by: Matthew Schwartz <matthew.schwartz@xxxxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> drivers/acpi/platform_profile.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/platform_profile.c
> b/drivers/acpi/platform_profile.c
> index d0198d2ccb551..f2f2274e4d83e 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -180,6 +180,12 @@ int platform_profile_register(struct
> platform_profile_handler *pprof)
> {
> int err;
>
> + /* Sanity check the profile handler */
> + if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
> + !pprof->profile_set || !pprof->profile_get) {
> + pr_err("platform_profile: handler is invalid\n");
> + return -EINVAL;
> + }
> if (!pprof->dev) {
> pr_err("platform_profile: handler device is not set\n");
> return -EINVAL;
> @@ -192,13 +198,6 @@ int platform_profile_register(struct
> platform_profile_handler *pprof)
> return -EEXIST;
> }
>
> - /* Sanity check the profile handler field are set */
> - if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
> - !pprof->profile_set || !pprof->profile_get) {
> - mutex_unlock(&profile_lock);
> - return -EINVAL;
> - }
> -
> err = sysfs_create_group(acpi_kobj, &platform_profile_group);
> if (err) {
> mutex_unlock(&profile_lock);
> --
> 2.43.0
Looks good to me.
Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
Mark
