Re: [PATCH] acpi thermal trip points increased to 12

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, 7 of April 2008, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@xxxxx>
> 
> The THERMAL_MAX_TRIPS value is set to 10. It is too few
> for the Compaq AP550 machine which has 12 trip points.

Looks sane to me, but it's better to CC the maintainers.

> Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx>
> ---
> 
> This patch was done against 2.6.25-rc8.
> 
> diff -urp linux-2.6.24/drivers/thermal/thermal.c linux-2.6.25/drivers/thermal/thermal.c
> --- linux-2.6.24/drivers/thermal/thermal.c	2008-04-07 23:18:14.712300799 +0200
> +++ linux-2.6.25/drivers/thermal/thermal.c	2008-04-07 23:47:23.531550750 +0200
> @@ -196,6 +196,10 @@ static struct device_attribute trip_poin
>  	__ATTR(trip_point_8_temp, 0444, trip_point_temp_show, NULL),
>  	__ATTR(trip_point_9_type, 0444, trip_point_type_show, NULL),
>  	__ATTR(trip_point_9_temp, 0444, trip_point_temp_show, NULL),
> +	__ATTR(trip_point_10_type, 0444, trip_point_type_show, NULL),
> +	__ATTR(trip_point_10_temp, 0444, trip_point_temp_show, NULL),
> +	__ATTR(trip_point_11_type, 0444, trip_point_type_show, NULL),
> +	__ATTR(trip_point_11_temp, 0444, trip_point_temp_show, NULL),
>  };
>  
>  #define TRIP_POINT_ATTR_ADD(_dev, _index, result)     \
> diff -urp linux-2.6.24/include/linux/thermal.h linux-2.6.25/include/linux/thermal.h
> --- linux-2.6.24/include/linux/thermal.h	2008-04-07 23:18:41.681807171 +0200
> +++ linux-2.6.25/include/linux/thermal.h	2008-04-07 23:26:24.201330930 +0200
> @@ -50,7 +50,7 @@ struct thermal_cooling_device_ops {
>  };
>  
>  #define THERMAL_TRIPS_NONE -1
> -#define THERMAL_MAX_TRIPS 10
> +#define THERMAL_MAX_TRIPS 12
>  #define THERMAL_NAME_LENGTH 20
>  struct thermal_cooling_device {
>  	int id;
> --

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux