On Wed, Oct 16, 2024 at 02:14:55PM +0300, Kirill A. Shutemov wrote:
> Calculation of 'next' virtual address doesn't protect against wrapping
> to zero. It can result in page table corruption and hang. The
> problematic case is possible if user sets high x86_mapping_info::offset.
>
> The wrapping to zero only occurs if the top PGD entry is accessed.
> There are no such users in the upstream. Only hibernate_64.c uses
> x86_mapping_info::offset, and it operates on the direct mapping range,
> which is not the top PGD entry.
>
> Replace manual 'next' calculation with p?d_addr_end() which handles
> wrapping correctly.
So this is a fix for a theoretical issue as it cannot happen currently?
Can we call that out in the commit message so that the stable AI doesn't pick
it up?
And which commit is it fixing?
aece27851d44 ("x86, 64bit, mm: Add generic kernel/ident mapping helper")
perhaps?
Always add Fixes: tags when a patch is fixing something - you know that.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
